From: Marius Gavrilescu Date: Thu, 14 Jul 2016 07:16:24 +0000 (+0100) Subject: Make OFF_URL easier to override and add documentation X-Git-Tag: 1.000003~1 X-Git-Url: http://git.ieval.ro/?p=www-offliberty.git;a=commitdiff_plain;h=fe61815ed3b848f80fa3c66b94fe783036fdb1fc Make OFF_URL easier to override and add documentation --- diff --git a/lib/WWW/Offliberty.pm b/lib/WWW/Offliberty.pm index 0162362..33740c8 100644 --- a/lib/WWW/Offliberty.pm +++ b/lib/WWW/Offliberty.pm @@ -7,7 +7,7 @@ use parent qw/Exporter/; our $VERSION = '1.000002'; our @EXPORT_OK = qw/off/; -use constant OFF_URL => 'http://offliberty.com/off03.php'; +our $OFF_URL = 'http://offliberty.com/off03.php'; use HTML::TreeBuilder; use HTTP::Tiny; @@ -16,7 +16,7 @@ our $http = HTTP::Tiny->new(agent => "WWW-Offliberty/$VERSION ", default_headers sub off{ my ($url, @params) = @_; - my $ret = $http->post_form(OFF_URL, {track => $url, @params}); + my $ret = $http->post_form($OFF_URL, {track => $url, @params}); die $ret->{reason} unless $ret->{success}; ## no critic (RequireCarping) my $root = HTML::TreeBuilder->new_from_content($ret->{content}); map { $_->attr('href') } $root->look_down(qw/_tag a class download/); @@ -53,6 +53,14 @@ audio-only URL when called with no parameters, and two URLs B set to B<1>. In contrast, Vimeo URLs with no parameters return both audio-only and audio/video variants. +Note: The URL of the service sometimes changes, which breaks this +module. If you notice this, please report a bug on RT. While the bug +is being fixed, you can override the URL locally by doing: + + $WWW::Offliberty:OFF_URL = 'http://offliberty.com/correct_url.php'; + +before calling off. + =head1 SEE ALSO L