From: Marius Gavrilescu Date: Sat, 13 Jul 2013 14:57:29 +0000 (+0300) Subject: Exit cleanly if there is no HOME environment variable X-Git-Tag: debian/2.1.0-3~9 X-Git-Url: http://git.ieval.ro/?a=commitdiff_plain;h=e34c1b5b2f32e8015072caad0169799462744655;p=gtk-theme-switch.git Exit cleanly if there is no HOME environment variable --- diff --git a/debian/changelog b/debian/changelog index 1411747..613ede8 100644 --- a/debian/changelog +++ b/debian/changelog @@ -6,6 +6,7 @@ gtk-theme-switch (2.1.0-3) UNRELEASED; urgency=low * Fix spelling error in help * Use dh-style debian/rules * Add hardening + * Exit cleanly if there is no HOME environment variable (Closes: #716007) -- Marius Gavrilescu Sat, 13 Jul 2013 16:31:46 +0300 diff --git a/debian/patches/exit-cleanly-when-we-have-no-homedir.patch b/debian/patches/exit-cleanly-when-we-have-no-homedir.patch new file mode 100644 index 0000000..0b30330 --- /dev/null +++ b/debian/patches/exit-cleanly-when-we-have-no-homedir.patch @@ -0,0 +1,26 @@ +Description: Exit when there is no HOME environment variable + The home directory is used in multiple places without checking + whether it is non-NULL. I think that it is very unlikely for + someone to want to use this program without that variable in + the environment, so we just bail out if it is missing. + . + If anyone wants gtk-theme-switch2 to work without a HOME + environment variable, they will surely file a bug about this. +Author: Marius Gavrilescu +Forwarded: no +Last-Update: 2013-07-13 + +--- a/main.c ++++ b/main.c +@@ -951,6 +951,11 @@ + newfont = 0; + execname = argv[0]; + homedir = getenv("HOME"); ++ if(homedir == NULL) ++ { ++ fprintf(stderr, "No HOME variable in environment, bailing out\n"); ++ return 0; ++ } + hash = g_hash_table_new (g_str_hash, g_str_equal); + + if (argc == 1) /* start in dock mode auto if no args */ diff --git a/debian/patches/series b/debian/patches/series index 213d22d..7039fe6 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ fix-spelling.patch +exit-cleanly-when-we-have-no-homedir.patch