From: Marius Gavrilescu <marius@ieval.ro>
Date: Tue, 3 Mar 2015 16:39:11 +0000 (+0200)
Subject: Remove no longer useful is_private and is_in_archive methods
X-Git-Tag: 5999.000_014~64
X-Git-Url: http://git.ieval.ro/?a=commitdiff_plain;h=f20668d742eae08b6e1d24048572bdeef0eb51d3;p=gruntmaster-data.git

Remove no longer useful is_private and is_in_archive methods
---

diff --git a/lib/Gruntmaster/Data/Result/Problem.pm b/lib/Gruntmaster/Data/Result/Problem.pm
index 2ce4f68..cec4cc8 100644
--- a/lib/Gruntmaster/Data/Result/Problem.pm
+++ b/lib/Gruntmaster/Data/Result/Problem.pm
@@ -332,18 +332,6 @@ after qw/insert update delete/ => sub {
 	Gruntmaster::Data::purge '/sol/' . $self->id;
 };
 
-sub is_private {
-	my ($self, $time) = @_;
-	return 0 if grep { !$_->contest->is_pending($time) } $self->contest_problems;
-	return 1 if $self->private;
-	grep { $_->contest->is_pending($time) } $self->contest_problems;
-}
-
-sub is_in_archive {
-	my ($self, $time) = @_;
-	0 == grep { $_->contest->is_running($time) } $self->contest_problems;
-}
-
 sub rerun {
 	$_->rerun for shift->jobs
 }
@@ -354,14 +342,6 @@ __END__
 
 =head1 METHODS
 
-=head2 is_private(I<[$time]>)
-
-Returns true if the problem is private at time I<$time> (which defaults to C<time>).
-
-=head2 is_in_archive(I<[$time]>)
-
-Returns true if the problem is in the archive at time I<$time> (which defaults to C<time>).
-
 =head2 rerun
 
 Reruns all jobs for this problem.
diff --git a/t/Gruntmaster-Data.t b/t/Gruntmaster-Data.t
index e9d20ac..3c97f06 100644
--- a/t/Gruntmaster-Data.t
+++ b/t/Gruntmaster-Data.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use v5.14;
 
-use Test::More tests => 13;
+use Test::More tests => 6;
 
 BEGIN { use_ok('Gruntmaster::Data') };
 
@@ -18,21 +18,3 @@ ok !$db->contest('rc')->is_pending(25), '!is_pending';
 ok $db->contest('fc')->is_finished(25), 'is_finished';
 ok !$db->contest('rc')->is_finished(25), '!is_finished';
 ok $db->contest('rc')->is_running(25), 'is_running';
-
-$db->problems->create({id => 'pb', name => 'Problem', generator => 'Undef', runner => 'File', judge => 'Absolute', level => 'beginner', value => 100, owner => 'MGV', statement => '...', testcnt => 1, timeout => 1, private => 0});
-
-ok !$db->problem('pb')->is_private(25), '!is_private';
-$db->problem('pb')->update({private => 1});
-ok $db->problem('pb')->is_private(25), 'is_private (explicit)';
-$db->problem('pb')->update({private => 0});
-
-$db->contest_problems->create({contest => 'pc', problem => 'pb'});
-ok $db->problem('pb')->is_private(25), 'is_private (implicit)';
-ok $db->problem('pb')->is_in_archive(25), 'is_in_archive';
-
-$db->contest_problems->create({contest => 'rc', problem => 'pb'});
-ok $db->problem('pb')->is_private(25), 'is_private (also implicit)';
-ok !$db->problem('pb')->is_in_archive(25), '!is_in_archive';
-
-$db->contest_problems->find('rc', 'pb')->delete;
-ok $db->problem('pb')->is_in_archive(25), 'is_in_archive (again)';