X-Git-Url: http://git.ieval.ro/?p=gruntmaster-daemon.git;a=blobdiff_plain;f=lib%2FGruntmaster%2FDaemon%2FFormat.pm;h=a51b6cb66ea6fc6ce3bff0b6a123ca9404e480d9;hp=5f503a117a534a4749294611034e2315dc8ebe93;hb=99d3711026b621247d46551b38f19c34f26342bd;hpb=920666a43b7af2544f3e27e7bfd6940534a18f90

diff --git a/lib/Gruntmaster/Daemon/Format.pm b/lib/Gruntmaster/Daemon/Format.pm
index 5f503a1..a51b6cb 100644
--- a/lib/Gruntmaster/Daemon/Format.pm
+++ b/lib/Gruntmaster/Daemon/Format.pm
@@ -15,7 +15,7 @@ use POSIX qw/mkfifo/;
 use String::ShellQuote qw/shell_quote/;
 use Try::Tiny;
 
-our $VERSION = "5999.000_004";
+our $VERSION = '5999.000_004';
 our @EXPORT_OK = qw/prepare_files stopvms/;
 
 ##################################################
@@ -47,11 +47,11 @@ sub execlist {
 		get_logger->trace("Running in VM $vm: $cmd");
 		$vm{$vm}->send($cmd);
 	} else {
-		my $ret = fork // die 'Cannot fork';
+		my $ret = fork // die "Cannot fork\n";
 		if ($ret) {
 			waitpid $ret, 0;
 		} else {
-			open STDOUT, ">$er";
+			open STDOUT, '>', $er or die "Cannot open $er\n";
 			exec 'gruntmaster-exec', @args;
 		}
 	}
@@ -59,9 +59,9 @@ sub execlist {
 	die "gruntmaster-exec died\n" if -z $er;
 	my ($excode, $exmsg) = read_file $er;
 	unlink $er;
-	chomp ($excode, $exmsg);
+	chomp ($excode, $exmsg); ## no critic (ProhibitParensWithBuiltins)
 	get_logger->trace("Exec result: $excode $exmsg");
-	die [$excode, $exmsg] if $excode > 0;
+	die [$excode, $exmsg] if $excode > 0; ## no critic (RequireCarping)
 }
 
 sub command_and_args{
@@ -83,7 +83,7 @@ sub mkrun{
 		local *__ANON__ = 'mkrun_runner';
 		my ($name, %args) = @_;
 		get_logger->trace("Running $name...");
-		my $basename = fileparse $name, qr/\.[^.]*/;
+		my $basename = fileparse $name, qr/[.][^.]*/s;
 		my @args;
 		push @args, '--timeout', $args{timeout} if $args{timeout};
 		push @args, '--mlimit',  $args{mlimit}  if $args{mlimit};