X-Git-Url: http://git.ieval.ro/?p=gruntmaster-data.git;a=blobdiff_plain;f=lib%2FGruntmaster%2FData.pm;h=694fc8e688eba12567f33bbe449b07888cf22a56;hp=b27444335bbc301b7cdd004031e146db0ecad686;hb=dcd72991e2d01ab1465afa494c0b6b4a1fd36e25;hpb=2431260b62f32021098cf47666afb335c708138f

diff --git a/lib/Gruntmaster/Data.pm b/lib/Gruntmaster/Data.pm
index b274443..694fc8e 100644
--- a/lib/Gruntmaster/Data.pm
+++ b/lib/Gruntmaster/Data.pm
@@ -29,14 +29,14 @@ use constant JOBS_PER_PAGE => 10;
 
 sub dynsub{
 	our ($name, $sub) = @_;
-	no strict 'refs';
+	no strict 'refs'; ## no critic (Strict)
 	*$name = subname $name => $sub
 }
 
 BEGIN {
 	for my $rs (qw/contest contest_problem job open problem user/) {
 		my $rsname = ucfirst $rs;
-		$rsname =~ s/_([a-z])/\u$1/g;
+		$rsname =~ s/_([a-z])/\u$1/gs;
 		dynsub PL_N($rs) => sub { $_[0]->resultset($rsname)              };
 		dynsub      $rs  => sub { $_[0]->resultset($rsname)->find($_[1]) };
 	}
@@ -66,15 +66,15 @@ sub standings {
 			next if $time < 0;
 			my $value = $job->problem->value;
 			my $factor = $job->result ? 0 : 1;
-			$factor = $1 / 100 if $job->result_text =~ /^(\d+ )/;
+			$factor = $1 / 100 if $job->result_text =~ /^(\d+ )/s;
 			$scores{$job->owner->id}{$job->problem->id} = int ($factor * calc_score ($value, $time, $tries{$job->owner->id}{$job->problem->id}++, $ct->stop - $ct->start));
 		} else {
-			no warnings 'numeric';
+			no warnings 'numeric'; ## no critic (ProhibitNoWarnings)
 			$scores{$job->owner->id}{$job->problem->id} = 0 + $job->result_text || ($job->result ? 0 : 100)
 		}
 	}
 
-	my @st = sort { $b->{score} <=> $a->{score} or $a->{user}->id cmp $b->{user}->id} map {
+	my @st = sort { $b->{score} <=> $a->{score} or $a->{user}->id cmp $b->{user}->id} map { ## no critic (ProhibitReverseSortBlock)
 		my $user = $_;
 		+{
 			user => $self->user($user),
@@ -91,7 +91,7 @@ sub standings {
 
 sub user_list {
 	my $rs = $_[0]->users->search(undef, {order_by => 'name', columns => USER_PUBLIC_COLUMNS});
-	[ map +{ $_->get_columns }, $rs->all ]
+	[ map { { $_->get_columns } } $rs->all ]
 }
 
 sub user_entry {
@@ -118,7 +118,7 @@ sub problem_entry {
 	my ($self, $id, $contest, $user) = @_;
 	my $pb = $self->problems->find($id, {columns => PROBLEM_PUBLIC_COLUMNS, prefetch => 'owner'});
 	my $running = $contest && $self->contest($contest)->is_running;
-	eval {
+	eval { ## no critic (RequireCheckingReturnValueOfEval)
 		$self->opens->create({
 			contest => $contest,
 			problem => $id,