From: Marius Gavrilescu Date: Tue, 31 Mar 2015 13:41:32 +0000 (+0300) Subject: Make perlcritic happy X-Git-Tag: 5999.000_014~34 X-Git-Url: http://git.ieval.ro/?p=gruntmaster-data.git;a=commitdiff_plain;h=6c0423f49be4a1e609bbcf961824097c07edbe1b Make perlcritic happy --- diff --git a/lib/Gruntmaster/Data.pm b/lib/Gruntmaster/Data.pm index dd0a92b..d8c7c31 100644 --- a/lib/Gruntmaster/Data.pm +++ b/lib/Gruntmaster/Data.pm @@ -1,5 +1,5 @@ package Gruntmaster::Data; -use v5.14; +use 5.014; use warnings; use parent qw/Exporter/; @@ -70,10 +70,10 @@ sub object_name { } -sub add_names ($) { +sub add_names ($) { ## no critic (ProhibitSubroutinePrototypes) my ($el) = @_; if (ref $el eq 'ARRAY') { - &add_names ($_) for @$el + &add_names ($_) for @$el ## no critic (ProhibitAmpersandSigils) } else { for my $object (qw/contest owner problem/) { my $table = $object eq 'owner' ? 'users' : "${object}s"; @@ -222,7 +222,6 @@ sub standings { my @problems = query(contest_problems_sth => $ct->{id})->flat; my $pblist = problem_list; my %values = query('problem_values_sth')->map; -# $values{$_} = $values{$_}->{value} for keys %values; my (%scores, %tries, %opens); my $opens = query(opens_sth => $ct->{id});