Make Gruntmaster::Page::Base also act as strict/warnings/feature/etc

[gruntmaster-page.git] / lib / Gruntmaster / Page / St.pm

diff --git a/lib/Gruntmaster/Page/St.pm b/lib/Gruntmaster/Page/St.pm
index 2186fea570647822782d3fb32f6a3492f0750c2c..3857c1ad22f991a6c5e5745b1ee5e6b9ef1a67d8 100644 (file)
--- a/lib/Gruntmaster/Page/St.pm
+++ b/lib/Gruntmaster/Page/St.pm
@@ -1,11 +1,6 @@
 package Gruntmaster::Page::St;
 
-use 5.014000;
-use strict;
-use warnings;
 use Gruntmaster::Page::Base st => 'Standings';
-our @ISA = qw/Gruntmaster::Page::Base/;
-our $VERSION = '0.001';
 
 use constant LEVEL_VALUES => {
        beginner => 100,
@@ -24,7 +19,7 @@ sub calc_score{
        $score = ($totaltime - $timetaken) / $totaltime * $score;
        $score -= $tries / 10 * $mxscore;
        $score = $mxscore * 3 / 10 if $score < $mxscore * 3 / 10;
-       int $score
+       int $score + 0.5
 }
 
 sub _generate{
@@ -43,15 +38,15 @@ sub _generate{
        @problems = sort @problems;
        my (%scores, %tries);
        for (1 .. jobcard) {
+               next unless defined job_user && defined job_problem && defined job_result;
+               next if $Gruntmaster::Data::contest && job_date() < $start;
+
                if ($Gruntmaster::Data::contest) {
+                       $scores{job_user()}{job_problem()} = job_result() ? 0 : calc_score (job_user(), job_problem(), job_date(), $tries{job_user()}{job_problem()}, $totaltime);
                        $tries{job_user()}{job_problem()}++;
-                       $scores{job_user()}{job_problem()} = job_result() ? 0 : calc_score (job_user(), job_problem(), job_date(), $tries{job_user()}{job_problem()}, $totaltime) if job_date() > $start;
-               } elsif (defined job_user && defined job_problem && defined job_result) {
-                       if (defined job_result_text && job_result_text =~ m/^(\scores+)/) {
-                               $scores{job_user()}{job_problem()} = $ct;
-                       } else {
-                               $scores{job_user()}{job_problem()} = job_result() ? 0 : 100;
-                       }
+               } else {
+                       no warnings 'numeric';
+                       $scores{job_user()}{job_problem()} = 0 + job_result_text() || (job_result() ? 0 : 100)
                }
        }