X-Git-Url: http://git.ieval.ro/?p=unical.git;a=blobdiff_plain;f=.pmd;h=7edda501d680929ac28f9520d65452bbd7092453;hp=5b88d72fb63e7e8537d2046b198f8ba9a6075924;hb=00b0fd8e83bd390790342ebc41148f4a760d9fb4;hpb=5cf4714f0675349ed599707e024cf0e70fe114b2 diff --git a/.pmd b/.pmd index 5b88d72..7edda50 100644 --- a/.pmd +++ b/.pmd @@ -4,256 +4,268 @@ .ruleset - LooseCoupling - Type Resolution Rules + AbstractClassWithoutAbstractMethod + Design Rules - CloneMethodMustImplementCloneable - Type Resolution Rules + AbstractClassWithoutAnyMethod + Design Rules - UnusedImports - Type Resolution Rules + AbstractNaming + Naming Rules - SignatureDeclareThrowsException - Type Resolution Rules + AccessorClassGeneration + Design Rules - IfStmtsMustUseBraces - Braces Rules + AddEmptyString + Optimization Rules - WhileLoopsMustUseBraces - Braces Rules + AppendCharacterWithChar + String and StringBuffer Rules - IfElseStmtsMustUseBraces - Braces Rules + ArrayIsStoredDirectly + Security Code Guidelines - ForLoopsMustUseBraces - Braces Rules + AssignmentInOperand + Controversial Rules - UseSingleton + AssignmentToNonFinalStatic Design Rules - SimplifyBooleanReturns - Design Rules + AtLeastOneConstructor + Controversial Rules - SimplifyBooleanExpressions - Design Rules + AvoidAccessibilityAlteration + Controversial Rules - SwitchStmtsShouldHaveDefault - Design Rules + AvoidArrayLoops + Optimization Rules - AvoidDeeplyNestedIfStmts - Design Rules + AvoidAssertAsIdentifier + Migration Rules - AvoidReassigningParameters - Design Rules + AvoidCallingFinalize + Finalizer Rules - SwitchDensity - Design Rules + AvoidCatchingNPE + Strict Exception Rules - ConstructorCallsOverridableMethod - Design Rules + AvoidCatchingThrowable + Strict Exception Rules - AccessorClassGeneration + AvoidConstantsInterface Design Rules - FinalFieldCouldBeStatic - Design Rules + AvoidDecimalLiteralsInBigDecimalConstructor + Basic Rules - CloseResource + AvoidDeeplyNestedIfStmts Design Rules - NonStaticInitializer - Design Rules + AvoidDollarSigns + Naming Rules - DefaultLabelNotLastInSwitchStmt - Design Rules + AvoidDuplicateLiterals + String and StringBuffer Rules - NonCaseLabelInSwitchStatement - Design Rules + AvoidEnumAsIdentifier + Migration Rules - OptimizableToArrayCall - Design Rules + AvoidFieldNameMatchingMethodName + Naming Rules - BadComparison - Design Rules + AvoidFieldNameMatchingTypeName + Naming Rules - EqualsNull - Design Rules + AvoidFinalLocalVariable + Controversial Rules - ConfusingTernary + AvoidInstanceofChecksInCatchClause Design Rules - InstantiationToGetClass - Design Rules + AvoidMultipleUnaryOperators + Basic Rules - IdempotentOperations + AvoidProtectedFieldInFinalClass Design Rules - SimpleDateFormatNeedsLocale + AvoidReassigningParameters Design Rules - ImmutableField - Design Rules + AvoidRethrowingException + Strict Exception Rules - UseLocaleWithCaseConversions - Design Rules + AvoidStringBufferField + String and StringBuffer Rules - AvoidProtectedFieldInFinalClass + AvoidSynchronizedAtMethodLevel Design Rules - AssignmentToNonFinalStatic - Design Rules + AvoidThreadGroup + Basic Rules - MissingStaticMethodInNonInstantiatableClass - Design Rules + AvoidThrowingNewInstanceOfSameException + Strict Exception Rules - AvoidSynchronizedAtMethodLevel - Design Rules + AvoidThrowingNullPointerException + Strict Exception Rules - MissingBreakInSwitch - Design Rules + AvoidThrowingRawExceptionTypes + Strict Exception Rules - UseNotifyAllInsteadOfNotify - Design Rules + AvoidUsingHardCodedIP + Basic Rules - AvoidInstanceofChecksInCatchClause - Design Rules + AvoidUsingNativeCode + Controversial Rules - AbstractClassWithoutAbstractMethod - Design Rules + AvoidUsingOctalValues + Basic Rules - SimplifyConditional - Design Rules + AvoidUsingShortType + Controversial Rules - CompareObjectsWithEquals - Design Rules + AvoidUsingVolatile + Controversial Rules - PositionLiteralsFirstInComparisons + BadComparison Design Rules - UnnecessaryLocalBeforeReturn - Design Rules + BigIntegerInstantiation + Basic Rules - NonThreadSafeSingleton - Design Rules + BooleanGetMethodName + Naming Rules - UncommentedEmptyMethod - Design Rules + BooleanInstantiation + Basic Rules - UncommentedEmptyConstructor - Design Rules + BooleanInversion + Controversial Rules - AvoidConstantsInterface - Design Rules + BrokenNullCheck + Basic Rules - UnsynchronizedStaticDateFormatter - Design Rules + ByteInstantiation + Migration Rules - PreserveStackTrace - Design Rules + CallSuperInConstructor + Controversial Rules - UseCollectionIsEmpty - Design Rules + CheckResultSet + Basic Rules + + + ClassCastExceptionWithToArray + Basic Rules + + + ClassNamingConventions + Naming Rules ClassWithOnlyPrivateConstructorsShouldBeFinal Design Rules - EmptyMethodInAbstractClassShouldBeAbstract - Design Rules + CloneMethodMustImplementCloneable + Type Resolution Rules - SingularField - Design Rules + CloneThrowsCloneNotSupportedException + Clone Implementation Rules - ReturnEmptyArrayRatherThanNull + CloseResource Design Rules - AbstractClassWithoutAnyMethod + CollapsibleIfStatements + Basic Rules + + + CompareObjectsWithEquals Design Rules - TooFewBranchesForASwitchStatement + ConfusingTernary Design Rules - AvoidCatchingThrowable - Strict Exception Rules + ConsecutiveLiteralAppends + String and StringBuffer Rules - SignatureDeclareThrowsException - Type Resolution Rules + ConstructorCallsOverridableMethod + Design Rules - ExceptionAsFlowControl - Strict Exception Rules + CouplingBetweenObjects + Coupling Rules - AvoidCatchingNPE - Strict Exception Rules + DefaultLabelNotLastInSwitchStmt + Design Rules - AvoidThrowingRawExceptionTypes - Strict Exception Rules + DefaultPackage + Controversial Rules - AvoidThrowingNullPointerException - Strict Exception Rules + DoNotCallGarbageCollectionExplicitly + Controversial Rules - AvoidRethrowingException - Strict Exception Rules + DoNotCallSystemExit + J2EE Rules DoNotExtendJavaLangError @@ -264,191 +276,203 @@ Strict Exception Rules - AvoidThrowingNewInstanceOfSameException - Strict Exception Rules + DoNotUseThreads + J2EE Rules - UnusedPrivateField - Unused Code Rules + DontImportJavaLang + Import Statement Rules - UnusedLocalVariable - Unused Code Rules + DontImportSun + Controversial Rules - UnusedPrivateMethod - Unused Code Rules + DoubleCheckedLocking + Basic Rules - UnusedFormalParameter - Unused Code Rules + DuplicateImports + Import Statement Rules - MoreThanOneLogger - Java Logging Rules + EmptyCatchBlock + Basic Rules - LoggerIsNotStaticFinal - Java Logging Rules - + EmptyFinalizer + Finalizer Rules + - SystemPrintln - Java Logging Rules + EmptyFinallyBlock + Basic Rules - AvoidPrintStackTrace - Java Logging Rules + EmptyIfStmt + Basic Rules - AvoidDuplicateLiterals - String and StringBuffer Rules + EmptyInitializer + Basic Rules - StringInstantiation - String and StringBuffer Rules + EmptyMethodInAbstractClassShouldBeAbstract + Design Rules - StringToString - String and StringBuffer Rules + EmptyStatementNotInLoop + Basic Rules - InefficientStringBuffering - String and StringBuffer Rules + EmptyStaticInitializer + Basic Rules - UnnecessaryCaseChange - String and StringBuffer Rules + EmptySwitchStatements + Basic Rules - UseStringBufferLength - String and StringBuffer Rules + EmptySynchronizedBlock + Basic Rules - AppendCharacterWithChar - String and StringBuffer Rules + EmptyTryBlock + Basic Rules - ConsecutiveLiteralAppends - String and StringBuffer Rules + EmptyWhileStmt + Basic Rules - UseIndexOfChar - String and StringBuffer Rules + EqualsNull + Design Rules - InefficientEmptyStringCheck - String and StringBuffer Rules + ExceptionAsFlowControl + Strict Exception Rules - InsufficientStringBufferDeclaration - String and StringBuffer Rules + ExcessiveClassLength + Code Size Rules - UselessStringValueOf - String and StringBuffer Rules + ExcessiveImports + Coupling Rules - StringBufferInstantiationWithChar - String and StringBuffer Rules + ExcessiveMethodLength + Code Size Rules - UseEqualsToCompareStrings - String and StringBuffer Rules + ExcessiveParameterList + Code Size Rules - AvoidStringBufferField - String and StringBuffer Rules + ExcessivePublicCount + Code Size Rules - ReplaceVectorWithList - Migration Rules + FinalFieldCouldBeStatic + Design Rules - ReplaceHashtableWithMap - Migration Rules + FinalizeDoesNotCallSuperFinalize + Finalizer Rules - ReplaceEnumerationWithIterator - Migration Rules + FinalizeOnlyCallsSuperFinalize + Finalizer Rules - AvoidEnumAsIdentifier - Migration Rules + FinalizeOverloaded + Finalizer Rules - AvoidAssertAsIdentifier - Migration Rules + FinalizeShouldBeProtected + Finalizer Rules - IntegerInstantiation - Migration Rules + ForLoopShouldBeWhileLoop + Basic Rules - ByteInstantiation - Migration Rules + IdempotentOperations + Design Rules - ShortInstantiation - Migration Rules + ImmutableField + Design Rules - LongInstantiation - Migration Rules + ImportFromSamePackage + Import Statement Rules - JUnit4TestShouldUseBeforeAnnotation - Migration Rules + InefficientEmptyStringCheck + String and StringBuffer Rules - JUnit4TestShouldUseAfterAnnotation - Migration Rules + InefficientStringBuffering + String and StringBuffer Rules - JUnit4TestShouldUseTestAnnotation + InstantiationToGetClass + Design Rules + + + InsufficientStringBufferDeclaration + String and StringBuffer Rules + + + IntegerInstantiation Migration Rules + + JumbledIncrementer + Basic Rules + JUnit4SuitesShouldUseSuiteAnnotation Migration Rules - JUnitUseExpected + JUnit4TestShouldUseAfterAnnotation Migration Rules - UseProperClassLoader - J2EE Rules + JUnit4TestShouldUseBeforeAnnotation + Migration Rules - MDBAndSessionBeanNamingConvention - J2EE Rules + JUnit4TestShouldUseTestAnnotation + Migration Rules - RemoteSessionInterfaceNamingConvention - J2EE Rules + JUnitAssertionsShouldIncludeMessage + JUnit Rules - LocalInterfaceSessionNamingConvention - J2EE Rules + JUnitSpelling + JUnit Rules - LocalHomeNamingConvention - J2EE Rules + JUnitStaticSuite + JUnit Rules - RemoteInterfaceNamingConvention - J2EE Rules + JUnitTestsShouldIncludeAssert + JUnit Rules - DoNotCallSystemExit - J2EE Rules + JUnitUseExpected + Migration Rules - StaticEJBFieldShouldBeFinal + LocalHomeNamingConvention J2EE Rules - DoNotUseThreads + LocalInterfaceSessionNamingConvention J2EE Rules @@ -456,490 +480,406 @@ Optimization Rules - MethodArgumentCouldBeFinal - Optimization Rules + LoggerIsNotStaticFinal + Java Logging Rules - AvoidInstantiatingObjectsInLoops - Optimization Rules + LongInstantiation + Migration Rules - UseArrayListInsteadOfVector - Optimization Rules + LooseCoupling + Type Resolution Rules - SimplifyStartsWith - Optimization Rules + MDBAndSessionBeanNamingConvention + J2EE Rules - UseStringBufferForStringAppends + MethodArgumentCouldBeFinal Optimization Rules - UseArraysAsList - Optimization Rules + MethodNamingConventions + Naming Rules - AvoidArrayLoops - Optimization Rules + MethodReturnsInternalArray + Security Code Guidelines - UnnecessaryWrapperObjectCreation - Optimization Rules + MethodWithSameNameAsEnclosingClass + Naming Rules - AddEmptyString - Optimization Rules + MisleadingVariableName + Naming Rules - EmptyCatchBlock + MisplacedNullCheck Basic Rules - EmptyIfStmt - Basic Rules + MissingBreakInSwitch + Design Rules - EmptyWhileStmt - Basic Rules + MissingSerialVersionUID + JavaBean Rules - EmptyTryBlock - Basic Rules + MissingStaticMethodInNonInstantiatableClass + Design Rules - EmptyFinallyBlock - Basic Rules + MoreThanOneLogger + Java Logging Rules - EmptySwitchStatements - Basic Rules + NcssConstructorCount + Code Size Rules - JumbledIncrementer - Basic Rules + NcssMethodCount + Code Size Rules - ForLoopShouldBeWhileLoop - Basic Rules + NcssTypeCount + Code Size Rules - UnnecessaryConversionTemporary - Basic Rules + NonCaseLabelInSwitchStatement + Design Rules - OverrideBothEqualsAndHashcode - Basic Rules + NonStaticInitializer + Design Rules - DoubleCheckedLocking - Basic Rules + NonThreadSafeSingleton + Design Rules - ReturnFromFinallyBlock - Basic Rules + NoPackage + Naming Rules - EmptySynchronizedBlock - Basic Rules + NullAssignment + Controversial Rules - UnnecessaryReturn - Basic Rules + OptimizableToArrayCall + Design Rules - EmptyStaticInitializer + OverrideBothEqualsAndHashcode Basic Rules - UnconditionalIfStatement - Basic Rules + PackageCase + Naming Rules - EmptyStatementNotInLoop - Basic Rules + PositionLiteralsFirstInComparisons + Design Rules - BooleanInstantiation - Basic Rules + PreserveStackTrace + Design Rules - UnnecessaryFinalModifier - Basic Rules + ProperCloneImplementation + Clone Implementation Rules - CollapsibleIfStatements - Basic Rules + ProperLogger + Jakarta Commons Logging Rules - UselessOverridingMethod - Basic Rules + RemoteInterfaceNamingConvention + J2EE Rules - ClassCastExceptionWithToArray - Basic Rules + RemoteSessionInterfaceNamingConvention + J2EE Rules - AvoidDecimalLiteralsInBigDecimalConstructor - Basic Rules + ReplaceEnumerationWithIterator + Migration Rules - UselessOperationOnImmutable - Basic Rules + ReplaceHashtableWithMap + Migration Rules - MisplacedNullCheck - Basic Rules + ReplaceVectorWithList + Migration Rules - UnusedNullCheckInEquals - Basic Rules + ReturnEmptyArrayRatherThanNull + Design Rules - AvoidThreadGroup + ReturnFromFinallyBlock Basic Rules - BrokenNullCheck - Basic Rules + ShortInstantiation + Migration Rules - BigIntegerInstantiation - Basic Rules + ShortMethodName + Naming Rules - AvoidUsingOctalValues - Basic Rules + SignatureDeclareThrowsException + Type Resolution Rules - AvoidUsingHardCodedIP - Basic Rules + SimpleDateFormatNeedsLocale + Design Rules - CheckResultSet - Basic Rules + SimplifyBooleanAssertion + JUnit Rules - AvoidMultipleUnaryOperators - Basic Rules + SimplifyBooleanExpressions + Design Rules - EmptyInitializer - Basic Rules + SimplifyBooleanReturns + Design Rules - MethodReturnsInternalArray - Security Code Guidelines + SimplifyConditional + Design Rules - ArrayIsStoredDirectly - Security Code Guidelines + SimplifyStartsWith + Optimization Rules - CouplingBetweenObjects - Coupling Rules + SingularField + Design Rules - ExcessiveImports - Coupling Rules + StaticEJBFieldShouldBeFinal + J2EE Rules - LooseCoupling - Type Resolution Rules + StringBufferInstantiationWithChar + String and StringBuffer Rules - DuplicateImports - Import Statement Rules + StringInstantiation + String and StringBuffer Rules - DontImportJavaLang - Import Statement Rules + StringToString + String and StringBuffer Rules - UnusedImports - Type Resolution Rules + SuspiciousConstantFieldName + Naming Rules - ImportFromSamePackage - Import Statement Rules + SuspiciousEqualsMethodName + Naming Rules - TooManyStaticImports - Import Statement Rules + SuspiciousHashcodeMethodName + Naming Rules - JUnitStaticSuite - JUnit Rules + SuspiciousOctalEscape + Controversial Rules - JUnitSpelling - JUnit Rules + SwitchDensity + Design Rules - JUnitAssertionsShouldIncludeMessage - JUnit Rules + SwitchStmtsShouldHaveDefault + Design Rules - JUnitTestsShouldIncludeAssert - JUnit Rules + SystemPrintln + Java Logging Rules TestClassWithoutTestCases JUnit Rules - UnnecessaryBooleanAssertion - JUnit Rules - - - UseAssertEqualsInsteadOfAssertTrue - JUnit Rules + TooManyFields + Code Size Rules - UseAssertSameInsteadOfAssertTrue - JUnit Rules + TooManyMethods + Code Size Rules - UseAssertNullInsteadOfAssertTrue - JUnit Rules + TooManyStaticImports + Import Statement Rules - SimplifyBooleanAssertion - JUnit Rules + UncommentedEmptyConstructor + Design Rules - UnnecessaryConstructor - Controversial Rules + UncommentedEmptyMethod + Design Rules - NullAssignment - Controversial Rules + UnconditionalIfStatement + Basic Rules - UnusedModifier - Controversial Rules + UnnecessaryBooleanAssertion + JUnit Rules - AssignmentInOperand - Controversial Rules + UnnecessaryCaseChange + String and StringBuffer Rules - AtLeastOneConstructor + UnnecessaryConstructor Controversial Rules - DontImportSun - Controversial Rules + UnnecessaryConversionTemporary + Basic Rules - SuspiciousOctalEscape - Controversial Rules + UnnecessaryFinalModifier + Basic Rules - CallSuperInConstructor - Controversial Rules + UnnecessaryLocalBeforeReturn + Design Rules UnnecessaryParentheses Controversial Rules - DefaultPackage - Controversial Rules - - - BooleanInversion - Controversial Rules - - - DataflowAnomalyAnalysis - Controversial Rules + UnnecessaryReturn + Basic Rules - AvoidFinalLocalVariable - Controversial Rules + UnnecessaryWrapperObjectCreation + Optimization Rules - AvoidUsingShortType - Controversial Rules + UnsynchronizedStaticDateFormatter + Design Rules - AvoidUsingVolatile - Controversial Rules + UnusedFormalParameter + Unused Code Rules - AvoidUsingNativeCode - Controversial Rules + UnusedImports + Type Resolution Rules - AvoidAccessibilityAlteration - Controversial Rules + UnusedLocalVariable + Unused Code Rules - DoNotCallGarbageCollectionExplicitly + UnusedModifier Controversial Rules - ShortMethodName - Naming Rules - - - VariableNamingConventions - Naming Rules - - - MethodNamingConventions - Naming Rules - - - ClassNamingConventions - Naming Rules - - - AbstractNaming - Naming Rules - - - AvoidDollarSigns - Naming Rules - - - MethodWithSameNameAsEnclosingClass - Naming Rules - - - SuspiciousHashcodeMethodName - Naming Rules - - - SuspiciousConstantFieldName - Naming Rules - - - SuspiciousEqualsMethodName - Naming Rules - - - AvoidFieldNameMatchingTypeName - Naming Rules - - - AvoidFieldNameMatchingMethodName - Naming Rules - - - NoPackage - Naming Rules - - - PackageCase - Naming Rules - - - MisleadingVariableName - Naming Rules - - - BooleanGetMethodName - Naming Rules - - - NPathComplexity - Code Size Rules - - - ExcessiveMethodLength - Code Size Rules - - - ExcessiveParameterList - Code Size Rules + UnusedNullCheckInEquals + Basic Rules - ExcessiveClassLength - Code Size Rules + UnusedPrivateField + Unused Code Rules - CyclomaticComplexity - Code Size Rules + UnusedPrivateMethod + Unused Code Rules - ExcessivePublicCount - Code Size Rules + UseArrayListInsteadOfVector + Optimization Rules - TooManyFields - Code Size Rules + UseArraysAsList + Optimization Rules - NcssMethodCount - Code Size Rules + UseAssertEqualsInsteadOfAssertTrue + JUnit Rules - NcssTypeCount - Code Size Rules + UseAssertNullInsteadOfAssertTrue + JUnit Rules - NcssConstructorCount - Code Size Rules + UseAssertSameInsteadOfAssertTrue + JUnit Rules - TooManyMethods - Code Size Rules + UseCollectionIsEmpty + Design Rules - EmptyFinalizer - Finalizer Rules + UseCorrectExceptionLogging + Jakarta Commons Logging Rules - FinalizeOnlyCallsSuperFinalize - Finalizer Rules + UseEqualsToCompareStrings + String and StringBuffer Rules - FinalizeOverloaded - Finalizer Rules + UseIndexOfChar + String and StringBuffer Rules - FinalizeDoesNotCallSuperFinalize - Finalizer Rules + UselessOperationOnImmutable + Basic Rules - FinalizeShouldBeProtected - Finalizer Rules + UselessOverridingMethod + Basic Rules - AvoidCallingFinalize - Finalizer Rules + UselessStringValueOf + String and StringBuffer Rules - UseCorrectExceptionLogging - Jakarta Commons Logging Rules + UseLocaleWithCaseConversions + Design Rules - ProperLogger - Jakarta Commons Logging Rules + UseNotifyAllInsteadOfNotify + Design Rules - BeanMembersShouldSerialize - JavaBean Rules + UseProperClassLoader + J2EE Rules - MissingSerialVersionUID - JavaBean Rules + UseSingleton + Design Rules - ProperCloneImplementation - Clone Implementation Rules + UseStringBufferForStringAppends + Optimization Rules - CloneThrowsCloneNotSupportedException - Clone Implementation Rules + UseStringBufferLength + String and StringBuffer Rules - CloneMethodMustImplementCloneable - Type Resolution Rules + VariableNamingConventions + Naming Rules false - true + false