projects
/
gruntmaster-daemon.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (from parent 1:
fb7e1b7
)
Make perlcritic happy
author
Marius Gavrilescu
<marius@ieval.ro>
Sat, 31 Oct 2015 23:43:06 +0000
(23:43 +0000)
committer
Marius Gavrilescu
<marius@ieval.ro>
Sat, 31 Oct 2015 23:43:06 +0000
(23:43 +0000)
lib/Gruntmaster/Daemon.pm
patch
|
blob
|
blame
|
history
lib/Gruntmaster/Daemon/Format.pm
patch
|
blob
|
blame
|
history
lib/Gruntmaster/Daemon/Judge/Points.pm
patch
|
blob
|
blame
|
history
t/perlcriticrc
patch
|
blob
|
blame
|
history
diff --git
a/lib/Gruntmaster/Daemon.pm
b/lib/Gruntmaster/Daemon.pm
index 03810bacc66264b41aacabd4f3277a93440c1da8..a726219ed1bc2e62070be89c6908bfefc043e4f8 100644
(file)
--- a/
lib/Gruntmaster/Daemon.pm
+++ b/
lib/Gruntmaster/Daemon.pm
@@
-121,7
+121,7
@@
sub process_job {
$meta->{timeout} = $timeout_override if defined $timeout_override;
$meta->{tests} = decode_json $pb->{tests} if $meta->{runner} eq 'File';
$job->{contest} &&= contest_entry($job->{contest});
$meta->{timeout} = $timeout_override if defined $timeout_override;
$meta->{tests} = decode_json $pb->{tests} if $meta->{runner} eq 'File';
$job->{contest} &&= contest_entry($job->{contest});
- delete $meta->{precnt} unless $job->{contest} && $job->{contest}{started} && !$job->{contest}{finished};
+ delete $meta->{precnt} unless $job->{contest} && $job->{contest}{started} && !$job->{contest}{finished};
## no critic (ProhibitNegativeExpressionsInUnlessAndUntilConditions)
$meta->{testcnt} = $meta->{precnt} if $meta->{precnt};
$meta->{files}{ver} = {
$meta->{testcnt} = $meta->{precnt} if $meta->{precnt};
$meta->{files}{ver} = {
diff --git
a/lib/Gruntmaster/Daemon/Format.pm
b/lib/Gruntmaster/Daemon/Format.pm
index 7b6f77bcc6c24527021b095e04dbe58f55181897..d5560db420622331cef2c9206926718f10ab50e5 100644
(file)
--- a/
lib/Gruntmaster/Daemon/Format.pm
+++ b/
lib/Gruntmaster/Daemon/Format.pm
@@
-45,7
+45,7
@@
sub execlist_finish {
my ($vm, $kill) = @_;
if ($vm{$vm}) {
my ($vm, $kill) = @_;
if ($vm{$vm}) {
- warn "Cannot kill VM" if $kill;
+ warn "Cannot kill VM
\n
" if $kill;
$vm{$vm}->expect(5, '# ');
} else {
kill KILL => $pid{$vm} if $kill;
$vm{$vm}->expect(5, '# ');
} else {
kill KILL => $pid{$vm} if $kill;
diff --git
a/lib/Gruntmaster/Daemon/Judge/Points.pm
b/lib/Gruntmaster/Daemon/Judge/Points.pm
index 66286b22806d4c3cdb35c3bf161355f79f30848e..26c19f9ab42ba2aee551b535f60d8264290285b6 100644
(file)
--- a/
lib/Gruntmaster/Daemon/Judge/Points.pm
+++ b/
lib/Gruntmaster/Daemon/Judge/Points.pm
@@
-13,7
+13,7
@@
our $VERSION = '5999.000_004';
##################################################
sub judge{
##################################################
sub judge{
- no warnings qw/numeric/;
## no critic (ProhibitNoWarnings)
+ no warnings qw/numeric/;
get_logger->trace("Judging results: @_");
my $points = sum 0, grep { !ref } @_;
$points == 100 ? (result => AC, result_text => 'Accepted') : (result => REJ, result_text => "$points points", points => $points)
get_logger->trace("Judging results: @_");
my $points = sum 0, grep { !ref } @_;
$points == 100 ? (result => AC, result_text => 'Accepted') : (result => REJ, result_text => "$points points", points => $points)
diff --git
a/t/perlcriticrc
b/t/perlcriticrc
index 96564febd7b10f93624d02c8ce45084583b63ba8..40b151e9e752b7399ac462bf9ee6afa1f27387b2 100644
(file)
--- a/
t/perlcriticrc
+++ b/
t/perlcriticrc
@@
-7,8
+7,11
@@
severity = 1
[-Documentation::PodSpelling]
[-Documentation::RequirePodLinksIncludeText]
[-InputOutput::RequireBracedFileHandleWithPrint]
[-Documentation::PodSpelling]
[-Documentation::RequirePodLinksIncludeText]
[-InputOutput::RequireBracedFileHandleWithPrint]
+[-Modules::ProhibitAutomaticExportation]
[-References::ProhibitDoubleSigils]
[-RegularExpressions::ProhibitEnumeratedClasses]
[-References::ProhibitDoubleSigils]
[-RegularExpressions::ProhibitEnumeratedClasses]
+[-RegularExpressions::ProhibitUnusualDelimiters]
+[-RegularExpressions::RequireBracesForMultiline]
[-RegularExpressions::RequireLineBoundaryMatching]
[-Subroutines::RequireFinalReturn]
[-ValuesAndExpressions::ProhibitConstantPragma]
[-RegularExpressions::RequireLineBoundaryMatching]
[-Subroutines::RequireFinalReturn]
[-ValuesAndExpressions::ProhibitConstantPragma]
@@
-33,3
+36,6
@@
script_sections = NAME | SYNOPSIS | DESCRIPTION | AUTHOR | COPYRIGHT AND LICENSE
[Subroutines::RequireArgUnpacking]
short_subroutine_statements = 5
allow_subscripts = 1
[Subroutines::RequireArgUnpacking]
short_subroutine_statements = 5
allow_subscripts = 1
+
+[TestingAndDebugging::ProhibitNoWarnings]
+allow_with_category_restriction = 1
This page took
0.013923 seconds
and
4
git commands to generate.